Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure correct parsing of teachers moving school #70

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Ensure correct parsing of teachers moving school #70

merged 7 commits into from
Oct 25, 2023

Conversation

stefpiatek
Copy link
Collaborator

@stefpiatek stefpiatek commented Oct 11, 2023 •
edited
Loading

Adding in the school id to the pupil so that we can ensure that when a teacher moves school, we get the correct pupils

katiebuntic
katiebuntic approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@katiebuntic katiebuntic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@stefpiatek
Merge pull request #71 from UCL-ARC/sort_masterfile
4335809 
Sort masterfile for reporting
@stefpiatek stefpiatek merged commit c66ede4 into main Oct 25, 2023
7 checks passed
@stefpiatek stefpiatek deleted the teacher_moved_school branch October 25, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiebuntic katiebuntic katiebuntic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefpiatek @katiebuntic