Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

School aliases in extract #57

Merged
merged 12 commits into from
Sep 1, 2023
Merged

School aliases in extract #57

merged 12 commits into from
Sep 1, 2023

Conversation

katiebuntic
Copy link
Collaborator

I have had a go but still failing so need another try tomorrow! Is this kinda on the right track?

I am not 100% sure how to set the self._school_alias 🤔

stefpiatek
stefpiatek reviewed Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@stefpiatek stefpiatek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A couple of comments for some early feedback. I expect some other tests may fail because we've added more rows to the dispatch list data, so might need to update the expected results if it seems like that's the case

input/school_aliases/template.toml Outdated Show resolved Hide resolved
src/rred_reports/redcap/main.py Outdated Show resolved Hide resolved
src/rred_reports/redcap/main.py Outdated Show resolved Hide resolved
src/rred_reports/redcap/main.py Outdated Show resolved Hide resolved
@katiebuntic
Copy link
Collaborator Author

@stefpiatek thanks for the help - sorry final re-review! all checks have passed yay! i just changed one of the tests test_read_redcap_extract_rows_and_cols

stefpiatek
stefpiatek approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks for working on this

tests/test_redcap.py Show resolved Hide resolved
@stefpiatek stefpiatek merged commit bcf1c3a into main Sep 1, 2023
7 checks passed
@stefpiatek stefpiatek deleted the school_aliases_in_extract branch September 1, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefpiatek stefpiatek stefpiatek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katiebuntic @stefpiatek