Uat feedback on report generation #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryjmoss
reviewed
Jun 2, 2023
harryjmoss
reviewed
Jun 2, 2023
harryjmoss
reviewed
Jun 2, 2023
harryjmoss
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Great stuff, thanks for this @stefpiatek! Couple of minor & very minor comments
Co-authored-by: Harry Moss <[email protected]>
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some further feedback on report generation, ended up having to do some digging into why differences were occuring so added those in to the running of the export and report generation. Also writing out date format so correcting dates in excel isn't a horrible experience!
I think this should be the last substantial change, RRED may want to send a test email to all teacher leaders only, and then send out reports to leaders and teachers but will see when we get to that as it should be pretty straightforward to change