Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rulesets docs for renovate #5

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add rulesets docs for renovate #5

merged 2 commits into from
Nov 6, 2023

Conversation

paddyroddy
Copy link
Member

No description provided.

@paddyroddy paddyroddy added the documentation Improvements or additions to documentation label Oct 31, 2023
@paddyroddy paddyroddy self-assigned this Oct 31, 2023
samcunliffe
samcunliffe reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, but I'd err towards using the renovate names for things.
GitHub rulesets are a thing, but renovate seems to just call them "Configuration options".

renovate/README.md Outdated Show resolved Hide resolved
@paddyroddy
Copy link
Member Author

All good, but I'd err towards using the renovate names for things. GitHub rulesets are a thing, but renovate seems to just call them "Configuration options".

Considering that, you have to add rulsets to GitHub (AKA nothing to do with renovate). I don't really follow.

@samcunliffe
Copy link
Member

rulsets to GitHub (AKA nothing to do with renovate). I don't really follow.

Ah then it's just my confusion. You started talking about rulesets in renovate/README.md and it wasn't clear what you meant.

samcunliffe
samcunliffe approved these changes Nov 5, 2023
View reviewed changes
renovate/README.md Outdated Show resolved Hide resolved
@paddyroddy
Copy link
Member Author

Ah then it's just my confusion. You started talking about rulesets in renovate/README.md and it wasn't clear what you meant.

To be fair, if you read the whole README, I talk about branch protection & then rulesets.

@paddyroddy @samcunliffe
Add link to rulesets
9022483 
Co-authored-by: Sam Cunliffe <[email protected]>
@paddyroddy paddyroddy enabled auto-merge (squash) November 6, 2023 10:43
@paddyroddy paddyroddy merged commit 7b25441 into main Nov 6, 2023
1 check passed
@paddyroddy paddyroddy deleted the paddyroddy-patch-1 branch November 6, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcunliffe samcunliffe samcunliffe approved these changes

@HChughtai HChughtai Awaiting requested review from HChughtai

Assignees

@paddyroddy paddyroddy

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paddyroddy @samcunliffe