Merge pull request #64 from rissangs/main

Change graph file format from png to svg
UBC-MDS · Dec 11, 2020 · beeb6bb · beeb6bb
2 parents 78a1ccc + 5d23a64
commit beeb6bb
Show file tree

Hide file tree

Showing 39 changed files with 472 additions and 173 deletions.
diff --git a/Makefile b/Makefile
@@ -11,7 +11,7 @@
 
 # all: results/best_Model.pkl results/final_model_quality.png reports/reports.md
 
-all: results/wine_quality_rank_per_feature.png results/final_model_quality.png reports/reports.md
+all: results/wine_quality_rank_per_feature.svg results/final_model_quality.png reports/reports.md
 
 # download wine data set to directory
 data/raw/winequality-red.csv: src/download_data.py
@@ -25,7 +25,7 @@ data/processed/processed.csv data/processed/processed_test.csv data/processed/pr
 	python src/pre_processing_wine.py --in_file_1="data/raw/winequality-red.csv" --in_file_2="data/raw/winequality-white.csv" --out_dir="data/processed/"
 
 # create exploratory data analysis figure and write to file
-results/wine_quality_rank_per_feature.png: eda/wine_eda.py data/processed/processed.csv
+results/wine_quality_rank_per_feature.svg: eda/wine_eda.py data/processed/processed.csv
 	python eda/wine_eda.py -i data/processed/processed.csv -o eda/wine_EDA_files/
 
 # fitting model
@@ -42,7 +42,7 @@ reports/reports.md: reports/reports.Rmd reports/wine_refs.bib
 
 clean: 
 	rm -rf data
-	rm eda/wine_EDA_files/wine_quality_rank_per_feature.png
+	rm eda/wine_EDA_files/wine_quality_rank_per_feature.svg
 	rm -rf results
 	rm reports/reports.md
 

diff --git a/debug.log b/debug.log
@@ -0,0 +1,2 @@
+[1211/231809.780:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3)
+[1211/231813.467:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3)
diff --git a/eda/wine_EDA_files/correlation_matrix.png b/eda/wine_EDA_files/correlation_matrix.png
diff --git a/eda/wine_EDA_files/correlation_matrix.svg b/eda/wine_EDA_files/correlation_matrix.svg
diff --git a/eda/wine_EDA_files/density_facet.png b/eda/wine_EDA_files/density_facet.png
diff --git a/eda/wine_EDA_files/density_facet.svg b/eda/wine_EDA_files/density_facet.svg
diff --git a/eda/wine_EDA_files/distribution_of_numeric_features.png b/eda/wine_EDA_files/distribution_of_numeric_features.png
diff --git a/eda/wine_EDA_files/distribution_of_numeric_features.svg b/eda/wine_EDA_files/distribution_of_numeric_features.svg
diff --git a/eda/wine_EDA_files/distribution_of_type_of_wine.png b/eda/wine_EDA_files/distribution_of_type_of_wine.png
diff --git a/eda/wine_EDA_files/distribution_of_type_of_wine.svg b/eda/wine_EDA_files/distribution_of_type_of_wine.svg
diff --git a/eda/wine_EDA_files/distribution_of_wine_quality.png b/eda/wine_EDA_files/distribution_of_wine_quality.png
diff --git a/eda/wine_EDA_files/distribution_of_wine_quality.svg b/eda/wine_EDA_files/distribution_of_wine_quality.svg
diff --git a/eda/wine_EDA_files/distribution_of_wine_quality_regrouped.png b/eda/wine_EDA_files/distribution_of_wine_quality_regrouped.png
diff --git a/eda/wine_EDA_files/sugar_facet.png b/eda/wine_EDA_files/sugar_facet.png
diff --git a/eda/wine_EDA_files/sugar_facet.svg b/eda/wine_EDA_files/sugar_facet.svg
diff --git a/eda/wine_EDA_files/wine_EDA_13_0.png b/eda/wine_EDA_files/wine_EDA_13_0.png
diff --git a/eda/wine_EDA_files/wine_EDA_16_0.png b/eda/wine_EDA_files/wine_EDA_16_0.png
diff --git a/eda/wine_EDA_files/wine_EDA_18_0.png b/eda/wine_EDA_files/wine_EDA_18_0.png
diff --git a/eda/wine_EDA_files/wine_EDA_21_0.png b/eda/wine_EDA_files/wine_EDA_21_0.png
diff --git a/eda/wine_EDA_files/wine_EDA_25_1.png b/eda/wine_EDA_files/wine_EDA_25_1.png
diff --git a/eda/wine_EDA_files/wine_EDA_29_0.png b/eda/wine_EDA_files/wine_EDA_29_0.png
diff --git a/eda/wine_EDA_files/wine_EDA_32_0.png b/eda/wine_EDA_files/wine_EDA_32_0.png
diff --git a/eda/wine_EDA_files/wine_EDA_35_0.png b/eda/wine_EDA_files/wine_EDA_35_0.png
diff --git a/eda/wine_EDA_files/wine_EDA_38_0.png b/eda/wine_EDA_files/wine_EDA_38_0.png
diff --git a/eda/wine_EDA_files/wine_quality_rank.png b/eda/wine_EDA_files/wine_quality_rank.png
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		[1211/231809.780:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3)
		[1211/231813.467:ERROR:directory_reader_win.cc(43)] FindFirstFile: The system cannot find the path specified. (0x3)