Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker for Kitodo.Production #1

Open
stweil opened this issue May 25, 2016 · 3 comments
Open

Docker for Kitodo.Production #1

stweil opened this issue May 25, 2016 · 3 comments

Comments

@stweil
Copy link
Member

stweil commented May 25, 2016

Known issues:

  • missing documentation fixed in latest version by manually adding some documentation
  • crash after login when selecting "Meine Aufgaben" (maybe caused by my experimental code) fixed in latest version

Open questions:

  • Currently the database URL must be set in hibernate.cfg.xml, so that file must exist before starting Tomcat. For Docker, a runtime configuration using environment variables would be better. I added some code which should support this but which is not used at start up.
@stweil
Copy link
Member Author

stweil commented May 29, 2016

Known issues:

  • wrong encoding of German umlauts (for example Göttingen in "Administration / Benutzer")
  • Goobi in "Allgemeines / Technischer Hintergrund"
  • text in "Impressum"
  • missing installation of plugins

@zuphilip
Copy link
Member

The instruction worked for running kitodo-production as a docker container worked without any problem. ✨ Now, when I log in and click around the logs are flooded endlessly with some statements:

$ docker logs kitodo-production
...
        endElement(http://java.sun.com/JSF/Configuration,component-type,componen
t-type)
DEBUG 2016-05-29 19:47:57,265 org.apache.commons.digester.Digester.endElement(Di
gester.java:1167)
          match='faces-config/component/component-type'
DEBUG 2016-05-29 19:47:57,265 org.apache.commons.digester.Digester.endElement(Di
gester.java:1168)
          bodyText='org.ajax4jsf.Bundle'
DEBUG 2016-05-29 19:47:57,265 org.apache.commons.digester.Digester.endElement(Di
gester.java:1190)
          Fire body() for CallParamRule[paramIndex=0, attributeName=null, from s
tack=false]
DEBUG 2016-05-29 19:47:57,265 org.apache.commons.digester.Digester.endElement(Di
gester.java:1210)
          Popping body text ''
DEBUG 2016-05-29 19:47:57,265 org.apache.commons.digester.Digester.endElement(Di
gester.java:1220)
          Fire end() for CallParamRule[paramIndex=0, attributeName=null, from st
ack=false]
DEBUG 2016-05-29 19:47:57,265 org.apache.commons.digester.Digester.ignorableWhit
espace(Digester.java:1287)
        ignorableWhitespace(
    )
DEBUG 2016-05-29 19:47:57,266 org.apache.commons.digester.Digester.startElement(
Digester.java:1410)
        startElement(http://java.sun.com/JSF/Configuration,component-class,compo
nent-class)
DEBUG 2016-05-29 19:47:57,266 org.apache.commons.digester.Digester.startElement(
Digester.java:1417)
          Pushing body text ''
DEBUG 2016-05-29 19:47:57,266 org.apache.commons.digester.Digester.startElement(
Digester.java:1436)
          New match='faces-config/component/component-class'
DEBUG 2016-05-29 19:47:57,266 org.apache.commons.digester.Digester.startElement(
Digester.java:1451)
          Fire begin() for CallParamRule[paramIndex=1, attributeName=null, from
stack=false]
DEBUG 2016-05-29 19:47:57,266 org.apache.commons.digester.Digester.characters(Di
gester.java:1094)
        characters(org.ajax4jsf.component.html.AjaxLoadBundle)
DEBUG 2016-05-29 19:47:57,266 org.apache.commons.digester.Digester.endElement(Di
gester.java:1164)
        endElement(http://java.sun.com/JSF/Configuration,component-class,compone
nt-class)
DEBUG 2016-05-29 19:47:57,266 org.apache.commons.digester.Digester.endElement(Di
gester.java:1167)

@stweil
Copy link
Member Author

stweil commented May 29, 2016

That's caused by commit 3cf9c62 where I enabled debug logging because I needed it while testing the docker image.

stweil added a commit that referenced this issue Apr 7, 2017
CID 44591 (#1 of 1): Unintended regular expression (REGEX_CONFUSION)
CID 44894 (#1 of 1): Dm: Dubious method used (FB.DM_DEFAULT_ENCODING)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
This fixes a warning from Coverity:

CID 44606 (#1 of 1): Logically dead code (DEADCODE)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
Coverity Scan report:

CID 44634 (#1 of 1): Resource leak (RESOURCE_LEAK)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
CID 44715 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
CID 44587 (#1 of 1): Resource leak on an exceptional path (RESOURCE_LEAK)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
CID 44607 (#1 of 1): Resource leak on an exceptional path (RESOURCE_LEAK)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
Errors reported by Coverity Scan:

CID 50569 (#1 of 1): Resource leak on an exceptional path (RESOURCE_LEAK)
CID 50570 (#1 of 1): Resource leak on an exceptional path (RESOURCE_LEAK)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
Coverity report:
CID 44605 (#1 of 1): Resource leak (RESOURCE_LEAK)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
Coverity report:
CID 44654 (#1 of 1): Missing break in switch (MISSING_BREAK)

Moving the code for the default case out of the switch statement
and cleaning the if / else statements improves the readability.

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
Coverity report:
CID 44599 (#1 of 1): Missing break in switch (MISSING_BREAK)
CID 44630 (#1 of 1): Missing break in switch (MISSING_BREAK)
CID 44718 (#1 of 1): Missing break in switch (MISSING_BREAK)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
Coverity report:
CID 44688 (#1 of 1): Cross-site scripting (XSS)
CID 135806 (#1 of 1): Cross-site scripting (XSS)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
CID 44603 (#1 of 1): Resource leak (RESOURCE_LEAK)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
Coverity reports these issues:

CID 44583 (#1-2 of 2): Dereference after null check (FORWARD_NULL)
CID 44891 (#1 of 1): Dm: Dubious method used (FB.DM_DEFAULT_ENCODING)

Signed-off-by: Stefan Weil <[email protected]>
stweil added a commit that referenced this issue Apr 7, 2017
Coverity report: CID 44624 (#1 of 1): Wrong method called (WRONG_METHOD)

Signed-off-by: Stefan Weil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants