RefreshObject: Fix resource leak

Coverity report: CID 44605 (#1 of 1): Resource leak (RESOURCE_LEAK) Signed-off-by: Stefan Weil <[email protected]>
UB-Mannheim · Oct 3, 2016 · b60e771 · b60e771
1 parent e4f5d16
commit b60e771
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/Goobi/src/de/sub/goobi/helper/RefreshObject.java b/Goobi/src/de/sub/goobi/helper/RefreshObject.java
@@ -76,21 +76,29 @@ public static void refreshProcess_GUI(int processID) {
 		if(logger.isDebugEnabled()){
 			logger.debug("refreshing process with id " + processID);
 		}
+		Session session = null;
+		boolean needsClose = false;
 		try {
-			Session session = Helper.getHibernateSession();
+			session = Helper.getHibernateSession();
 			if (session == null || !session.isOpen() || !session.isConnected()) {
 				logger.debug("session is closed, creating a new session");
 				HibernateUtilOld.rebuildSessionFactory();
 				session = HibernateUtilOld.getSessionFactory().openSession();
+				needsClose = true;
 			}
 			Prozess o = (Prozess) session.get(Prozess.class, processID);
 			logger.debug("loaded process");
 			session.refresh(o);
 			logger.debug("refreshed process");
-			// session.close();
-			// logger.debug("closed session");
+			if (needsClose) {
+				session.close();
+				logger.debug("closed session");
+			}
 		} catch (Throwable e) {
 			logger.error("cannot refresh process with id " + processID);
+			if (needsClose) {
+				session.close();
+			}
 		}
 	}