adding diff_opts to allow adding aditional helm diff options.
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @Tang8330 ! can you take a look at this short PR when you have a chance? |
|
@Typositoire can you take a look if you have a chance? |
Tang8330
previously approved these changes
Aug 24, 2024
|
Sorry @duxing, code lgtm |
|
@Tang8330 sry I forgot to bump version, can you re-review? |
Tang8330
approved these changes
Aug 24, 2024
|
@Tang8330 sry to bother you again, if it's okay to you, can you help me merge the PR?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can be helpful in situations where you have to add additional options to
diffcommand.e.g. if your
helmchart containslookupfunction, you need to specify--dry-run=servertodiffcommand (context)with
diff_opts, it can be supported easily as the example in README.md