Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous build fixes #184

Merged
merged 16 commits into from
Dec 3, 2023
Merged

Miscellaneous build fixes #184

merged 16 commits into from
Dec 3, 2023

Conversation

arch1t3cht
Copy link
Collaborator

Various small fixes to building and installer generation that came up on arch1t3cht/Aegisub .

The two most "controversial" commits are at the bottom:

  • Avisynth is broken anyway (at least for now), so the paths could also just be taken out
  • The commit that adds bundling of the hunspell dictionaries downloads them from Sourceforge (mainly to document where they came from), but that download fails quite frequently on the CI. So maybe it's better to just check them into the repo or use some newer dictionary.

arch1t3cht and others added 9 commits December 3, 2023 21:10
@arch1t3cht
installer and ci: Throw more errors on failure
b660e46 
This makes it easier to notice when installer generation failed.
@arch1t3cht
mac: Use latest git version for ffms2
5d06972
@arch1t3cht
meson: Add libresrc headers as dependencies
05231e4 
These are included in the Aegisub source files, so they need to be
generated before compiling.
@seproDev @arch1t3cht
meson: Add nasm fallback url
b57597c 
Nasm's website goes down quite frequently, which breaks ci builds.
@arch1t3cht
Fix OSX library wrangling when libs use @rpath or @loader_path
68e54b7 
Fixes arch1t3cht#77
@arch1t3cht
meson: luajit: Set correct LUAJIT_TARGET for buildvm
ae66d27 
On native builds this is derived automatically, but on cross builds
it needs to be set explicitly.
@arch1t3cht
meson: luajit: Remove checkdef for SSE
665c1f3 
This isn't actually set in luajit's Makefile. Maybe it was at some
point in the past, but there's no trace of it now.

Fixes arch1t3cht#98 .
@arch1t3cht
meson: Use crash_writer_minidump on Windows
ede7ed5 
This was done in Aegisub/Aegisub.
@arch1t3cht
Fix Avisynth paths in installer and portable
d6de813
@CoffeeFlux
Copy link
Member

Leaving the paths commit in is fine. I'm less excited about the sourceforge bit, though I agree with the need to indicate where they came from. How big are they and how frequently are they updated?

@arch1t3cht
Copy link
Collaborator Author

They're around 250KB and weren't updated since... 2007.

@CoffeeFlux
Copy link
Member

How often do see you see the downloads fail? I'm leaning towards "just check in the dictionaries" but don't feel particularly strongly.

@arch1t3cht
Copy link
Collaborator Author

Looking through a couple of old CI runs, around 25% of the time

@CoffeeFlux
Copy link
Member

That's pretty bad. Are they hosted anywhere else we could use as a fallback?

@arch1t3cht
Copy link
Collaborator Author

I don't think so, they're pretty old after all and most applications just use SCOWL nowadays.

@CoffeeFlux
Copy link
Member

I really don't want to check in the dictionaries to the main repo -- can you dump them in a repo in TSTools and download from Github's CDN?

@arch1t3cht
Copy link
Collaborator Author

Yeah, done.

@arch1t3cht
Ship en_US hunspell dictionaries on Windows and OSX
59e26f9 
For now, this uses the same OpenOffice dictionaries that were used in
previous official releases, downloaded from
https://sourceforge.net/projects/openofficeorg.mirror/files/contrib/dictionaries/
In the future this could be updated to some newer dictionary like
SCOWL's.

Fixes arch1t3cht#21.
@arch1t3cht
Fix crash_writer_minidump after switch to C++20
a9ddb10
@CoffeeFlux CoffeeFlux merged commit 0e2a14c into master Dec 3, 2023
5 checks passed
@arch1t3cht arch1t3cht deleted the misc_build_fixes branch December 3, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arch1t3cht @CoffeeFlux @seproDev