Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RangeError when un-nesting certain blocks #797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewlipski
Copy link
Collaborator

This PR fixes an error caused when trying to un-nest blocks which have children.

Closes #481
Closes #598

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 3, 2024 4:52pm
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 3, 2024 4:52pm

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this introduces some bugs:

bug nesting

@sb8244
Copy link

sb8244 commented Aug 4, 2024

May be unrelated, I'm attempting to use this function to fix liftListItem in a function I'm creating.

The result when calling it is that all indentation is removed. So instead of going up 1 level, it goes to the root.

It may be a side effect of the function I'm writing (trying to have sinkListItem only affect the single node that's selected) though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants