refactor: contentRef prop into useContent hook
#789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Couple of questions (I think we should leave this improvement for a later cycle regardless though):
- wdym with
contentReffeels hacky? A hook is a different API but I wouldn't consider one to be more "hacky" than the other? Especially since the hook just returns a ref, so practically it comes down to the same thing right? - I suppose the benefit of this approach is that we can return more props (style and data-node-view-content) to the element?
- Why do we need the data-node-view-content again / why didn't we need this before?
- "hooks run async" -> this isn't the case. A hook is just the same as a regular function call. So the bug must be somewhere else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hacky fix used for the
contentRefprop by refactoring it into auseContentprop. Now setting the editable element in a React block is done via this hook instead of thecontentRefprop.Closes #659
TODO: There are currently a pretty big problem in that because this uses a hook which runs asynchronously, exporting to HTML does not properly serialize the content.