Internal html changes #1116
Merged
Internal html changes #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…te into internal-html-changes
YousefED
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Sweet, almost there! Couple of small questions
Regarding testing; curious whether the tests we created also work with the original code and if we can see if the original code breaks the tests and the new code fixes it. That way we know for sure our tests + code do what we need :) Let's discuss!
...e/src/api/exporters/html/__snapshots_fragment_edge_cases__/selectionLeavesBlockChildren.html
Show resolved
Hide resolved
packages/core/src/blocks/TableBlockContent/TableBlockContent.ts
Outdated
Show resolved
Hide resolved
YousefED
reviewed
Oct 2, 2024
packages/core/src/blocks/TableBlockContent/TableBlockContent.ts
Outdated
Show resolved
Hide resolved
…te into internal-html-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1064
closes #1110