feat: Added resolveFileUrl block ID field
#1107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Sep 30, 2024
| public readonly resolveFileUrl: (url: string) => Promise<string>; | ||
| public readonly resolveFileUrl: ( | ||
| url: string, | ||
| blockId?: string |
There was a problem hiding this comment.
shouldn't this parameter be required? Or are there cases when it's undefined? If so, I think we should document those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a block ID field to
resolveFileUrlas there seems to be a use case for it as per this Discord thread.Also fixes the upload file button not including the block ID when calling
editor.uploadFile, and the video block not callingeditor.resolveUrl.