Don't abuse PRNG -> fix identifier generation when building on Windows #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pseudorandom number generators need to be initialized only once. Using the system time for this is Generally Fine, but re-initializing the PRNG in a tight loop every time a random number is needed significantly raises the odds that the same number sequence (or even the same number) is returned every time. Chances for this to happen on Windows are apparently much higher than on Linux. Not sure why this is the case, my best guess is that the clock used for Go's `time.Now()´ runs with coarser granularity.
|
@Tylous Is this PR at all interesting to you? |
|
This is needed for it to work on Windows as well as Linux and and OSX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pseudorandom number generators need to be initialized only once.
Using the system time for this is Generally Fine, but re-initializing
the PRNG in a tight loop every time a random number is needed
significantly raises the odds that the same number sequence (or even
the same number) is returned every time.
Chances for this to happen on Windows are apparently much higher than
on Linux. Not sure why this is the case, my best guess is that the
clock used for Go's `time.Now()´ runs with coarser granularity.