Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-12495 - support RSAPSS #5709

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

TT-12495 - support RSAPSS #5709

wants to merge 1 commit into from

Conversation

sedkis
Copy link
Contributor

@sedkis sedkis commented Nov 12, 2024

User description

For internal users - Please add a Jira DX PR ticket to the subject!



Preview Link


Description


Screenshots (if appropriate)


Checklist

  • I have added a preview link to the PR description.
  • I have reviewed the suggestions made by our AI (PR Agent) and updated them accordingly (spelling errors, rephrasing, etc.)
  • I have reviewed the guidelines for contributing to this repository.
  • I have read the technical guidelines for contributing to this repository.
  • Make sure you have started your change off our latest master.
  • I labeled the PR

PR Type

documentation


Description

  • Added documentation for RSA and PSA classes of RSA algorithms supported by Tyk, including RS256, RS384, RS512, PS256, PS384, and PS512.
  • Provided guidance on selecting RSA signing methods in the Tyk Dashboard.
  • Included a reference link for understanding the differences between RSA and PSA algorithms.

Changes walkthrough 📝

Relevant files
Documentation
json-web-tokens.md
Document support for RSA and PSA algorithms in JWT authentication

tyk-docs/content/basic-config-and-security/security/authentication-authorization/json-web-tokens.md

  • Added a new section on RSA supported algorithms.
  • Listed supported RSA and PSA algorithms including RS256, RS384, RS512,
    PS256, PS384, and PS512.
  • Provided a link for further reading on RSA & PSA algorithm
    differences.
  • Explained how to use RSA signing methods in Tyk Dashboard.
  • +16/-0   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Clarity and Accuracy
    The section added about RSA and PSA algorithms might need a review for technical accuracy and clarity. Ensure that the terminology and descriptions are precise and understandable for users unfamiliar with these concepts.

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link

    netlify bot commented Nov 12, 2024

    PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit 9dc8f6f
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/67338043eb57040008698c36
    😎 Deploy Preview https://deploy-preview-5709--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @sharadregoti
    Copy link
    Contributor

    TODO: Once PR #5690 is merged, this PR will have conflicts. We’ll need to transfer the current content to the new page after the merge.

    @sharadregoti
    Copy link
    Contributor

    @sedkis As per our conversation. I am marking this PR as draft.

    @sharadregoti sharadregoti marked this pull request as draft November 21, 2024 08:35
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants