Fixed Maximum fee value option is not working as expected. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmimalpande
requested changes
Jul 4, 2024
| @@ -549,7 +549,7 @@ public function calculate_the_fee( $args, $final_fee_to_add, $total_in_cart, $fe | |||
| $max_fee = 0; | |||
| } | |||
| // Max fee. | |||
| if ( 0 != $max_fee && $new_fee > $max_fee ) { //phpcs:ignore | |||
| if ( 0 != $max_fee && $new_fee < $max_fee ) { //phpcs:ignore | |||
There was a problem hiding this comment.
@mokshasharmila13 This is incorrect. This will not work when the fee value & max fee value is a positive value. You need to check for both positive & negative values
rashmimalpande
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #235. Added a check when the maximum fees are set.