Fix #204 #209
Fix #204 #209
Conversation
There was a problem hiding this comment.
Code analysis identified issues
Tyche Softwares has identified potential problems in this pull request during automated scanning. We recommend reviewing the issues noted and that they are resolved.
phpcs scanning turned up:
🚫 2 errors
Powered by Tyche Softwares
| @@ -403,6 +403,9 @@ public function add_gateways_fees( $the_cart ) { | |||
| if ( strpos( $current_gateway, $klarna_payment ) !== false ) { | |||
| $current_gateway = 'klarna_payments'; | |||
| } | |||
| if ( strpos( $current_gateway, 'alma_in_page' ) !== false ) { | |||
| $current_gateway = 'alma'; | |||
| } | |||
There was a problem hiding this comment.
| @@ -403,6 +403,9 @@ | |||
| if ( strpos( $current_gateway, $klarna_payment ) !== false ) { | |||
| $current_gateway = 'klarna_payments'; | |||
| } | |||
| if ( strpos( $current_gateway, 'alma_in_page' ) !== false ) { | |||
| $current_gateway = 'alma'; | |||
| } | |||
There was a problem hiding this comment.
🚫 Error: Tabs must be used to indent lines; spaces are not allowed (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed).
| @@ -403,6 +403,9 @@ | |||
| if ( strpos( $current_gateway, $klarna_payment ) !== false ) { | |||
| $current_gateway = 'klarna_payments'; | |||
| } | |||
| if ( strpos( $current_gateway, 'alma_in_page' ) !== false ) { | |||
| $current_gateway = 'alma'; | |||
| } | |||
There was a problem hiding this comment.
🚫 Error: Line indented incorrectly; expected 3 tabs, found 1 tabs and 2 spaces (Generic.WhiteSpace.ScopeIndent.IncorrectExact).
tyche-bot
dismissed
their stale review
Dismissing review as all inline comments are obsolete by now
|
Scanning latest commit did not yield any new issues. Please have a look at older feedback still existing (commit-ID: ae0555c) Powered by Tyche Softwares |
Fixed fees issue with 'Alma - Pay in installments or later for WooCommerce' payments. Fix #204