add democracy #321
Draft
add democracy #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to turn the input sequence back into its original form was very error-prone, e.g. it didn't manage the `hold` special case right and would instead output `a+-`. I figured it'd be best to just remember the original texts instead.
Felk
commented
Apr 24, 2022
| { | ||
| Sequence = input.InputSets | ||
| .Select(set => set.Inputs | ||
| .Select(i => i.DisplayedText).ToList()).ToList(); |
There was a problem hiding this comment.
The old overlay relies on the input text to be regex-parseable to be recognized as a touch input and therefore displayed during execution, so this does not work for touchscreen aliases. Might be worth rethinking the wire format.
Note that in the old overlay the wire format for button sequences is shared across many places, and in particular with the anarchy_input_start event in regards to the touch detection logic (see check_button_set_for_touchscreen in old overlay touchscreen.js).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.