Add Channel Points Automatic Reward Redemption Add classes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Release] Version 2.5.2
AoshiW
suggested changes
May 12, 2024
Comment on lines
3
to
5
| using TwitchLib.EventSub.Core.Models.Chat; | ||
| namespace TwitchLib.EventSub.Core.SubscriptionTypes.Channel; | ||
| /// <summary> |
There was a problem hiding this comment.
missing new line
Suggested change
| using TwitchLib.EventSub.Core.Models.Chat; | |
| namespace TwitchLib.EventSub.Core.SubscriptionTypes.Channel; | |
| /// <summary> | |
| using TwitchLib.EventSub.Core.Models.Chat; | |
| namespace TwitchLib.EventSub.Core.SubscriptionTypes.Channel; | |
| /// <summary> |
Comment on lines
1
to
3
| using System; | ||
| namespace TwitchLib.EventSub.Core.Models.Chat; | ||
| /// <summary> |
There was a problem hiding this comment.
missing new line
Suggested change
| using System; | |
| namespace TwitchLib.EventSub.Core.Models.Chat; | |
| /// <summary> | |
| using System; | |
| namespace TwitchLib.EventSub.Core.Models.Chat; | |
| /// <summary> |
| /// <summary> | ||
| /// An array that includes the emote ID and start and end positions for where the emote appears in the text. | ||
| /// </summary> | ||
| public ChatMessageEmoteFragment[] Emotes { get; set; } = Array.Empty<ChatMessageEmoteFragment>(); |
There was a problem hiding this comment.
Suggested change
| public ChatMessageEmoteFragment[] Emotes { get; set; } = Array.Empty<ChatMessageEmoteFragment>(); | |
| public ChatMessageEmoteFragment[] Emotes { get; set; } = []; |
Comment on lines
1
to
2
| namespace TwitchLib.EventSub.Core.Models.Chat; | ||
| /// <summary> |
There was a problem hiding this comment.
missing new line
Suggested change
| namespace TwitchLib.EventSub.Core.Models.Chat; | |
| /// <summary> | |
| namespace TwitchLib.EventSub.Core.Models.Chat; | |
| | |
| /// <summary> |
Comment on lines
1
to
2
| namespace TwitchLib.EventSub.Core.Models.ChannelPoints; | ||
| /// <summary> |
There was a problem hiding this comment.
missing new line
Suggested change
| namespace TwitchLib.EventSub.Core.Models.ChannelPoints; | |
| /// <summary> | |
| namespace TwitchLib.EventSub.Core.Models.ChannelPoints; | |
| | |
| /// <summary> |
Comment on lines
1
to
2
| namespace TwitchLib.EventSub.Core.Models.ChannelPoints; | ||
| /// <summary> |
There was a problem hiding this comment.
missing new line
Suggested change
| namespace TwitchLib.EventSub.Core.Models.ChannelPoints; | |
| /// <summary> | |
| namespace TwitchLib.EventSub.Core.Models.ChannelPoints; | |
| | |
| /// <summary> |
| /// <summary> | ||
| /// Optional. Emote that was unlocked. | ||
| /// </summary> | ||
| public UnlockedEmote? UnlockedEmote { get; set; } = new(); |
There was a problem hiding this comment.
if it can be null, the default value is not set
Suggested change
| public UnlockedEmote? UnlockedEmote { get; set; } = new(); | |
| public UnlockedEmote? UnlockedEmote { get; set; } |
| /// The reward cost. | ||
| /// </summary> | ||
| public int Cost { get; set; } | ||
|
|
| /// </summary> | ||
| public sealed class AutomaticRedemptionReward | ||
| { | ||
|
|
| /// The text of the chat message. | ||
| /// </summary> | ||
| public string Text { get; set; } = string.Empty; | ||
|
|
|
@AoshiW Let me know if it looks good? |
AoshiW
approved these changes
May 12, 2024
|
Actually, can we target dev branch for this change instead of main? |
Sure @swiftyspiffy , but I dont know how I can swap the target to the dev branch in a pull request. But I can try to mess around and see if I can do something about it. |
|
Let me know if this was the correct way to swap the target. It should targeted the dev branch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names and scheme comes from this: https://dev.twitch.tv/docs/eventsub/eventsub-reference/#channel-points-automatic-reward-redemption-add-event
I noticed this subcription doesnt exist in the eventsub of TwitchLib, so I am doing an attempt to add the automatic reward redemption models to core, which then can be used in TwitchLib.EventSub.Websocket.
As it is my first pull request inside of here; let me know if there are any words that should be changed or anything that I forgot to add to the models.