add cron-schedule support to alerts by changing IsEnabled result #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is back-compatible. It suppresses alerts outside the user-defined crontab format schedule by setting enabled to false.
The goal is to suppress alerts with user-provided crontab formatted settings. It is somewhat similar to the current
maintenance
but allows more flexibility in setting the schedule. For example, ifcron-schedule
is set to* 9-18 * *
the alert will be disabled before 9:00 and after 18:59. I think, adding it on theAlert
level is the simplest solution here with the minimal code change.See discussion #250.
Checklist
README.md
, if applicable.Note: I'm not sure what is the proper section in the readme to add this info