Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove taintedness as it was removed in Ruby 3.2 #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkorpela
Copy link

Merging inifiles does not work because in dup it attempts to taint which is no longer available in 3.2.

@jkorpela jkorpela changed the title Remove taintedness as it was removes in Ruby 3.2 Remove taintedness as it was removed in Ruby 3.2 Apr 11, 2023
Copy link

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix the inifile gem with Ruby 3.2 💯 .

@smortex
Copy link

smortex commented Apr 20, 2023

For reference, these function have been no-op since Ruby 2.7 and where removed in Ruby 3.2:
https://bugs.ruby-lang.org/issues/16131

@TwP, do you still have enough cycles to handle this gem and do release?

@mhashizume mhashizume mentioned this pull request Sep 19, 2023
@graaff
Copy link

graaff commented Sep 30, 2023

There are also test for tainted? that should be removed from test_inifile.rb

@joshcooper
Copy link

@jkorpela couid you update your PR to remove tainted? from the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants