Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve evaluate function #148

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Improve evaluate function #148

merged 2 commits into from
Mar 6, 2024

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Mar 6, 2024

  • Refactor evaluate function for speed and clarity
  • simplify functions in BUGSPrimitives that have implementations from Stdlib

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.85%. Comparing base (4510c17) to head (46e2355).
Report is 2 commits behind head on master.

Files Patch % Lines
src/compiler_pass.jl 92.85% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   79.62%   80.85%   +1.23%     
==========================================
  Files          21       21              
  Lines        1978     1959      -19     
==========================================
+ Hits         1575     1584       +9     
+ Misses        403      375      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunxd3 sunxd3 merged commit 772c857 into master Mar 6, 2024
12 of 15 checks passed
@sunxd3 sunxd3 deleted the sunxd/improve_evaluate branch March 6, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant