Fix wrong implementation of distributions #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ext/JuliaBUGSAdvancedHMCExt.jl
Outdated
Comment on lines
47
to
48
| param_name_leaves = collect(Iterators.flatten( | ||
| [ |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| param_name_leaves = collect(Iterators.flatten( | |
| [ | |
| param_name_leaves = collect( | |
| Iterators.flatten([ |
ext/JuliaBUGSAdvancedHMCExt.jl
Outdated
Comment on lines
51
to
54
| ], | ||
| )) | ||
| generated_varname_leaves = collect(Iterators.flatten( | ||
| [ |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ], | |
| )) | |
| generated_varname_leaves = collect(Iterators.flatten( | |
| [ | |
| ],), | |
| ) | |
| generated_varname_leaves = collect( | |
| Iterators.flatten([ |
ext/JuliaBUGSAdvancedHMCExt.jl
Outdated
Comment on lines
57
to
58
| ], | ||
| )) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ], | |
| )) | |
| ],), | |
| ) |
ext/JuliaBUGSAdvancedHMCExt.jl
Outdated
| flattened_param_vals = [vcat(p...) for p in param_vals] | ||
| flattened_generated_quantities = [vcat(gq...) for gq in generated_quantities] | ||
| flattened_param_vals = [collect(Iterators.flatten(p)) for p in param_vals] | ||
| flattened_generated_quantities = [collect(Iterators.flatten(gq)) for gq in generated_quantities] |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| flattened_generated_quantities = [collect(Iterators.flatten(gq)) for gq in generated_quantities] | |
| flattened_generated_quantities = [ | |
| collect(Iterators.flatten(gq)) for gq in generated_quantities | |
| ] |
src/BUGSPrimitives/distributions.jl
Outdated
| ), | ||
| ) | ||
| end | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 71.79% 71.45% -0.34%
==========================================
Files 16 16
Lines 1659 1671 +12
==========================================
+ Hits 1191 1194 +3
- Misses 468 477 +9
☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 6300765515
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.