-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Enzyme #67
Enable Enzyme #67
Conversation
@wsmoses It seems Enzyme is hitting some C++-level errors on |
So 1.7 and below have known GC bugs in Julia so support is weaker than
1.10. That said it should work so an MWE is welcome (and feel free to merge
1.10 here in the interim and we can follow up with a 1.7 PR once a MWE is
opened and fixed).
…On Sat, Aug 10, 2024 at 4:55 PM Kyurae Kim ***@***.***> wrote:
@wsmoses <https://github.com/wsmoses> It seems Enzyme is hitting some
C++-level errors on 1.7. All tests do pass on 1.10 though. Is Enzyme not
expected to work on 1.7 or should I try to pack a MWE just for 1.7?
—
Reply to this email directly, view it on GitHub
<#67 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXD6Q57IOE676CNBWZLZQZ443AVCNFSM6AAAAABJVGQH5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGI3TKMZXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@wsmoses Unfortunately, some of the tests on 1.10 are still failing, though I can't reproduce it locally. Seems like there is still some work left to do 😞 |
Hurray, all the tests finally passed! Thank you so much @wsmoses for the amazing real-time work! |
@Red-Portal Great work. Some minor comments on how to manage PRs for future reference: it is better to
This PR is causing lots of merging conflicts in #71. |
Currently, this PR depends on upstream the following upstream issues: