Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Enzyme #67

Merged
merged 20 commits into from
Aug 22, 2024
Merged

Enable Enzyme #67

merged 20 commits into from
Aug 22, 2024

Conversation

Red-Portal
Copy link
Member

  • Update Enzyme external dependency to match the new AD interface
  • Enable unit tests with Enzyme

Currently, this PR depends on upstream the following upstream issues:

@Red-Portal Red-Portal changed the title Enable Enzyme Enable Enzyme Jun 24, 2024
@yebai yebai mentioned this pull request Aug 7, 2024
ext/AdvancedVIEnzymeExt.jl Outdated Show resolved Hide resolved
@Red-Portal
Copy link
Member Author

@wsmoses It seems Enzyme is hitting some C++-level errors on 1.7. All tests do pass on 1.10 though. Is Enzyme not expected to work on 1.7 or should I try to pack a MWE just for 1.7?

@wsmoses
Copy link
Contributor

wsmoses commented Aug 10, 2024 via email

test/runtests.jl Outdated Show resolved Hide resolved
@Red-Portal
Copy link
Member Author

@wsmoses Unfortunately, some of the tests on 1.10 are still failing, though I can't reproduce it locally. Seems like there is still some work left to do 😞

@Red-Portal
Copy link
Member Author

Hurray, all the tests finally passed! Thank you so much @wsmoses for the amazing real-time work!

@Red-Portal Red-Portal merged commit d015eb5 into TuringLang:master Aug 22, 2024
9 of 10 checks passed
@yebai
Copy link
Member

yebai commented Aug 22, 2024

@Red-Portal Great work. Some minor comments on how to manage PRs for future reference: it is better to

  1. let someone else review the PR before merging.
  2. keep changes in PR specific to one thing, e.g. this PR changes lots of interfaces and internals, together with the Enzyme work

This PR is causing lots of merging conflicts in #71.

@Red-Portal Red-Portal deleted the enable_enzyme branch September 10, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants