CompatHelper: add new compat entry for ReverseDiff at version 1 for package bench, (keep existing compat) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ackage bench, (keep existing compat)
penelopeysm
force-pushed
the
compathelper/new_version/2024-10-05-00-20-57-102-01320502699
branch
from
7fd264c to
fd84f8c
Compare
There was a problem hiding this comment.
Benchmark Results
| Benchmark suite | Current: fd84f8c | Previous: 462ca92 | Ratio |
|---|---|---|---|
normal + bijector/meanfield/ForwardDiff |
481118769 ns |
482568396 ns |
1.00 |
normal + bijector/meanfield/ReverseDiff |
194399549 ns |
195335919.5 ns |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
yebai
deleted the
compathelper/new_version/2024-10-05-00-20-57-102-01320502699
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets the compat entry for the
ReverseDiffpackage to1for package bench.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.