Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks #104

Merged
merged 13 commits into from
Oct 5, 2024
Merged

Add benchmarks #104

merged 13 commits into from
Oct 5, 2024

Conversation

Red-Portal
Copy link
Member

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark suite Current: e1b73d1 Previous: e3f4ebe Ratio
normal/RepGradELBO + STL/meanfield/Zygote 16366548689 ns
normal/RepGradELBO + STL/meanfield/ForwardDiff 3807423535 ns
normal/RepGradELBO + STL/meanfield/ReverseDiff 3444803407 ns
normal/RepGradELBO + STL/fullrank/Zygote 16065365046 ns
normal/RepGradELBO + STL/fullrank/ForwardDiff 3989996038 ns
normal/RepGradELBO + STL/fullrank/ReverseDiff 6038326874 ns
normal/RepGradELBO/meanfield/Zygote 7769013493 ns
normal/RepGradELBO/meanfield/ForwardDiff 2762268219 ns
normal/RepGradELBO/meanfield/ReverseDiff 1599652964.5 ns
normal/RepGradELBO/fullrank/Zygote 7759257280 ns
normal/RepGradELBO/fullrank/ForwardDiff 2934152142 ns
normal/RepGradELBO/fullrank/ReverseDiff 2792433412 ns
normal + bijector/RepGradELBO + STL/meanfield/Zygote 25248641250 ns
normal + bijector/RepGradELBO + STL/meanfield/ForwardDiff 10590352879 ns
normal + bijector/RepGradELBO + STL/meanfield/ReverseDiff 4843928161 ns
normal + bijector/RepGradELBO + STL/fullrank/Zygote 24668374338 ns
normal + bijector/RepGradELBO + STL/fullrank/ForwardDiff 10284659780 ns
normal + bijector/RepGradELBO + STL/fullrank/ReverseDiff 8156482358 ns
normal + bijector/RepGradELBO/meanfield/Zygote 15925881628 ns
normal + bijector/RepGradELBO/meanfield/ForwardDiff 8416677298 ns
normal + bijector/RepGradELBO/meanfield/ReverseDiff 2860882948 ns
normal + bijector/RepGradELBO/fullrank/Zygote 15692956402 ns
normal + bijector/RepGradELBO/fullrank/ForwardDiff 8631554819 ns
normal + bijector/RepGradELBO/fullrank/ReverseDiff 4335877525 ns

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (0aa93e0) to head (e1b73d1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   93.65%   92.06%   -1.59%     
==========================================
  Files          12       12              
  Lines         378      378              
==========================================
- Hits          354      348       -6     
- Misses         24       30       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Red-Portal Red-Portal requested a review from yebai October 4, 2024 17:20
@Red-Portal
Copy link
Member Author

Mooncake and Enzyme have been disabled due to errors. I am currently trying to track the issues down!

@Red-Portal Red-Portal added this to the v0.3.0 milestone Oct 4, 2024
@yebai yebai requested a review from penelopeysm October 4, 2024 18:24
Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As someone who hasn't looked into the repo before, maybe the only thing that might be nice is to add some short instructions on how to run the benchmarks in bench/README.md:

]instantiate
]dev ../
include("benchmarks.jl")

bench/benchmarks.jl Outdated Show resolved Hide resolved
@Red-Portal Red-Portal merged commit 65d93ae into master Oct 5, 2024
12 of 13 checks passed
@Red-Portal Red-Portal deleted the add_more_benchmarks branch October 5, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants