Skip to content

Commit

Permalink
Un*x vncviewer: Don't pass -d32 to 32-bit JRE
Browse files Browse the repository at this point in the history
4baa429 removed the -d64 option that
the Un*x vncviewer script traditionally passed to the java executable,
because Java 9+ no longer supports that option.  However, the -d32
option was retained when using a 32-bit JRE.  That decision was probably
based on the false assumption that, because Oracle doesn't provide a
32-bit Java 9+ JRE for Un*x, one can only use Java 8- with 32-bit Un*x
systems.  However, there are some 32-bit Linux distributions out there
that compile their own 32-bit OpenJDK 9+ implementations, and the use of
-d32 breaks those implementations.
  • Loading branch information
dcommander committed Jun 16, 2023
1 parent 9dc7110 commit 9218efe
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions unix/vncviewer/vncviewer.in
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,4 @@ else
LD_LIBRARY_PATH=$JAWT_PATH:$LD_LIBRARY_PATH
export LD_LIBRARY_PATH
fi
if [ "@BITS@" = "32" ]; then
exec $JAVA -server -d@BITS@ -Djava.library.path=$TVNC_JAVADIR -jar $TVNC_JAVADIR/VncViewer.jar ${1+"$@"}
else
exec $JAVA -server -Djava.library.path=$TVNC_JAVADIR -jar $TVNC_JAVADIR/VncViewer.jar ${1+"$@"}
fi
exec $JAVA -server -Djava.library.path=$TVNC_JAVADIR -jar $TVNC_JAVADIR/VncViewer.jar ${1+"$@"}

0 comments on commit 9218efe

Please sign in to comment.