Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foxium compatibility #19

Closed
wants to merge 1 commit into from
Closed

foxium compatibility #19

wants to merge 1 commit into from

Conversation

1foxy2
Copy link

@1foxy2 1foxy2 commented Sep 9, 2024

compatibility with foxium (neoforge port of lithium)

@jpenilla
Copy link
Member

jpenilla commented Sep 9, 2024

As mentioned on Discord, I don't have time to keep up with the differences between the various unofficial Lithium ports. If you plan to maintain compatibility through PRs, it makes more sense to have that done in foxium itself, similar to what Radium has done (see #18). Also, foxium should use a unique mod id rather than lithium's.

@jpenilla jpenilla closed this Sep 9, 2024
@1foxy2
Copy link
Author

1foxy2 commented Sep 9, 2024

understandable. at first it had unique id but some mods are hardcoded to lithium mod id, so could you just remove the lithium incompatability?

@jpenilla
Copy link
Member

jpenilla commented Sep 10, 2024

I assume you mean Fabric mods loaded through connector? I don't think blanket marking Lithium compatibility is a good idea for a variety of reasons. It would be better to utilize Neo's equivalent of provides and adjusting the relevant mod's checks, or ideally connector would have some sort of mechanism to handle these cases.

@1foxy2
Copy link
Author

1foxy2 commented Sep 10, 2024

yes, through connector. the only way to fix incompat (other than mixin into each mod) i know is either jarjar dummy lithium mod or mixin in modcontainer$getModid to change foxium to lithium, but both will still be incompatible with moonrise.

@dima-dencep
Copy link

Foxium steal radium patches

@1foxy2
Copy link
Author

1foxy2 commented Sep 10, 2024

thats what happens when you don't update mod for 5 months. i also credit radium so i don't see a problem

@coco875
Copy link

coco875 commented Sep 10, 2024

why not just make a PR to update radium ?

@1foxy2
Copy link
Author

1foxy2 commented Sep 10, 2024

i thought radium was dead when making foxium. it is also easier to maintain if its my repo than doing infinite pr and waiting for the maintainer to accept them and publish.

@1foxy2
Copy link
Author

1foxy2 commented Sep 10, 2024

i would discontinued foxium but i don't think its
coincidence what radium stop updated when canary stopped but suddenly got updated when another fork was created

@dima-dencep
Copy link

I didn't update radium because of a bug in archloom, and I didn't have a server on neoforge

@1foxy2
Copy link
Author

1foxy2 commented Sep 10, 2024

then okay, i will discontinue foxium.

@Tuinity Tuinity locked as off-topic and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants