Fix incorrect fluid pushing velocity

Forgot to re-assign the flow vector variable with the scaled flow.
Tuinity · Sep 30, 2024 · 340ac4e · 340ac4e
1 parent a4770ac
commit 340ac4e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/fabric/src/main/java/ca/spottedleaf/moonrise/fabric/mixin/collisions/EntityMixin.java b/fabric/src/main/java/ca/spottedleaf/moonrise/fabric/mixin/collisions/EntityMixin.java
@@ -171,7 +171,7 @@ public boolean updateFluidHeightAndDoFluidPushing(final TagKey<Fluid> fluid, fin
             pushVector = pushVector.normalize();
         }
 
-        pushVector.scale(flowScale);
+        pushVector = pushVector.scale(flowScale);
         if (Math.abs(currMovement.x) < 0.003 && Math.abs(currMovement.z) < 0.003 && pushVector.length() < 0.0045000000000000005) {
             pushVector = pushVector.normalize().scale(0.0045000000000000005);
         }

diff --git a/neoforge/src/main/java/ca/spottedleaf/moonrise/neoforge/mixin/collisions/EntityMixin.java b/neoforge/src/main/java/ca/spottedleaf/moonrise/neoforge/mixin/collisions/EntityMixin.java
@@ -189,7 +189,7 @@ public void updateFluidHeightAndDoFluidPushing() {
                 pushVector = pushVector.normalize();
             }
 
-            pushVector.scale(this.getFluidMotionScale(type));
+            pushVector = pushVector.scale(this.getFluidMotionScale(type));
             if (Math.abs(currMovement.x) < 0.003 && Math.abs(currMovement.z) < 0.003 && pushVector.length() < 0.0045000000000000005) {
                 pushVector = pushVector.normalize().scale(0.0045000000000000005);
             }