Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AnimatedCounter.tsx #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Prajwalmegalamani
Copy link

Added fontWeight, padding and class as it was required in a project i was using

Added fontWeight, padding and class as it was required in a project i was using
Missed a defn in interface
@TuckerMassad
Copy link
Owner

TuckerMassad commented Apr 22, 2024

Hey @Prajwalmegalamani, thanks for the PR! I'm a little hesitant to simply add a className prop and then have the out-of-the-box styles be fighting against the styles in a given application's stylesheet. What are your thoughts on doing something like adding an optional digitStyles property where a user can pass in CSSProperties type attributes within an object similar to react's native style prop? Let me know your thoughts on these changes in a PR i've pointed toward's your branch https://github.com/Prajwalmegalamani/react-animated-counter/pull/1/files

@Prajwalmegalamani
Copy link
Author

Hey @Prajwalmegalamani, thanks for the PR! I'm a little hesitant to simply add a className prop and then have the out-of-the-box styles be fighting against the styles in a given application's stylesheet. What are your thoughts on doing something like adding an optional digitStyles property where a user can pass in CSSProperties type attributes within an object similar to react's native style prop? Let me know your thoughts on these changes in a PR i've pointed toward's your branch https://github.com/Prajwalmegalamani/react-animated-counter/pull/1/files

Hi @TuckerMassad , really appreciate you taking your time, I totally agree with your point, I will look at pr you have raised, Thank you

@TuckerMassad
Copy link
Owner

Hey @Prajwalmegalamani, checking in again here. Looks like the changes I proposed over here weren't actually merged into this PR brach. If you can go ahead and make those updates, i'll make sure to get this merged in! 😄

@TuckerMassad
Copy link
Owner

TuckerMassad commented May 16, 2024

Hi @Prajwalmegalamani, checking in again on this. I've published a new version of the package that includes two new properties containerStyles & digitStyles. You can use containerStyles to apply any CSS properties you'd like to the component parent element wrapper and digitStyles to apply CSS properties to the digit elements. This should accomplish what you are looking for. Let me know there is anything else on your end that you'd like and I'll go ahead and close out this PR 👍 Feel free to bump your package version to 1.7.9 to give it a whirl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants