Updated urlTransformMap to handle nested objects (#1376)

* Updated urlTransformMap to handle nested objects
TryGhost · Sep 5, 2024 · d8577b0 · d8577b0
1 parent 21bf5f1
commit d8577b0
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/packages/kg-default-nodes/lib/generate-decorator-node.js b/packages/kg-default-nodes/lib/generate-decorator-node.js
@@ -98,7 +98,11 @@ export function generateDecoratorNode({nodeType, properties = [], version = 1})
 
  properties.forEach((prop) => {
  if (prop.urlType) {
- map[prop.name] = prop.urlType;
+ if (prop.urlPath) {
+ map[prop.urlPath] = prop.urlType;
+ } else {
+ map[prop.name] = prop.urlType;
+ }
  }
  });
 

diff --git a/packages/kg-default-nodes/lib/nodes/bookmark/BookmarkNode.js b/packages/kg-default-nodes/lib/nodes/bookmark/BookmarkNode.js
@@ -11,8 +11,8 @@ export class BookmarkNode extends generateDecoratorNode({nodeType: 'bookmark',
  {name: 'caption', default: '', wordCount: true},
  {name: 'author', default: ''},
  {name: 'publisher', default: ''},
- {name: 'icon', default: '', urlType: 'url'},
- {name: 'thumbnail', default: '', urlType: 'url'}
+ {name: 'icon', urlPath: 'metadata.icon', default: '', urlType: 'url'},
+ {name: 'thumbnail', urlPath: 'metadata.thumbnail', default: '', urlType: 'url'}
  ]}
 ) {
  static importDOM() {

diff --git a/packages/kg-default-nodes/test/nodes/bookmark.test.js b/packages/kg-default-nodes/test/nodes/bookmark.test.js
@@ -133,9 +133,9 @@ describe('BookmarkNode', function () {
  describe('urlTransformMap', function () {
  it('contains the expected URL mapping', editorTest(function () {
  BookmarkNode.urlTransformMap.should.deepEqual({
- url: 'url',
- icon: 'url',
- thumbnail: 'url'
+ 'url': 'url',
+ 'metadata.icon': 'url',
+ 'metadata.thumbnail': 'url'
  });
  }));
  });
@@ -277,9 +277,9 @@ describe('BookmarkNode', function () {
 
  it('urlTransformMap', editorTest(function () {
  BookmarkNode.urlTransformMap.should.deepEqual({
- url: 'url',
- icon: 'url',
- thumbnail: 'url'
+ 'url': 'url',
+ 'metadata.icon': 'url',
+ 'metadata.thumbnail': 'url'
  });
  }));
  });