Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLUG-10: Resolve private key upload issues #28

Merged
merged 4 commits into from
Oct 28, 2024
Merged

PLUG-10: Resolve private key upload issues #28

merged 4 commits into from
Oct 28, 2024

Conversation

artyom-jaksov-tl
Copy link
Contributor

@artyom-jaksov-tl artyom-jaksov-tl commented Sep 3, 2024 •
edited
Loading

  • Use fixed filename for uploaded private key file
  • Use stored config value when deleting a file instead of accepting the filepath from the request.

@artyom-jaksov-tl artyom-jaksov-tl requested review from a team as code owners September 3, 2024 14:15
@swarmia Swarmia
Copy link

swarmia bot commented Sep 3, 2024

✅  Linked to Bug PLUG-10 · [Magento] Arbitrary file deletion in var directory by admin user deleting private key file
➡️  Part of Epic PLUG-113 · Magento - PHP contractor

@artyom-jaksov-tl artyom-jaksov-tl changed the title safer private key upload PLUG-10: Resolve private key upload issues Oct 8, 2024
@artyom-jaksov-tl artyom-jaksov-tl changed the base branch from main to develop October 8, 2024 09:16
@tl-ariel-reano tl-ariel-reano self-requested a review October 24, 2024 13:18
@artyom-jaksov-tl artyom-jaksov-tl merged commit 51c447a into develop Oct 28, 2024
10 checks passed
@artyom-jaksov-tl artyom-jaksov-tl deleted the feature/PLUG-10 branch October 28, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tl-security-scanner tl-security-scanner[bot] tl-security-scanner[bot] approved these changes

@tl-ariel-reano tl-ariel-reano tl-ariel-reano approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artyom-jaksov-tl @tl-ariel-reano