Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial pytest port of legacy tests #60

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Initial pytest port of legacy tests #60

merged 1 commit into from
Jul 5, 2023

Conversation

salvaom
Copy link
Collaborator

@salvaom salvaom commented Jul 5, 2023

Implements #10

@salvaom salvaom force-pushed the fix/i10-pytests branch from 5e0afd4 to f883be6 Compare July 5, 2023 16:56
rkoschmitzky
rkoschmitzky approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@rkoschmitzky rkoschmitzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! I will merge this so we have some tests already in place. But please also add docstrings.

@rkoschmitzky rkoschmitzky merged commit 886d6e4 into main Jul 5, 2023
@99alfie 99alfie linked an issue Aug 14, 2023 that may be closed by this pull request
Port and rework tests #10
Open
@99alfie 99alfie removed a link to an issue Aug 14, 2023
Port and rework tests #10
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkoschmitzky rkoschmitzky rkoschmitzky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salvaom @rkoschmitzky