Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port and rework tests #10

Open
rkoschmitzky opened this issue Jun 19, 2023 · 2 comments · May be fixed by #65
Open

Port and rework tests #10

rkoschmitzky opened this issue Jun 19, 2023 · 2 comments · May be fixed by #65
Assignees
@salvaom @99alfie
Labels
CI Continuous Integration enhancement New feature or request
Milestone
v0.1.0rc6

Comments

@rkoschmitzky
Copy link
Contributor

Goal

Add tests.

Motivation

The proprietary predecessor of Trackteroid had good test coverage. We have to identify if those tests can be ported and potentially rework them, but obviously, we need tests.

Considerations

We want to consider going fully with pytest instead of unittest.
@rkoschmitzky rkoschmitzky added enhancement New feature or request CI Continuous Integration labels Jun 19, 2023
@salvaom salvaom mentioned this issue Jun 20, 2023
Closed
@rkoschmitzky rkoschmitzky added this to the v0.1.0rc6 milestone Jul 4, 2023
@salvaom salvaom mentioned this issue Jul 5, 2023
Merged
@99alfie 99alfie mentioned this issue Aug 14, 2023
Closed
@99alfie 99alfie self-assigned this Aug 14, 2023
@99alfie 99alfie linked a pull request Aug 14, 2023 that will close this issue
Initial pytest port of legacy tests #60
Merged
@99alfie 99alfie removed a link to a pull request Aug 14, 2023
Initial pytest port of legacy tests #60
Merged
@99alfie
Copy link
Collaborator

99alfie commented Aug 16, 2023

in test_session.py, the following tests are failing:

test_reconnect_and_commit
test_get_cached_collections

both are reading a database file that has uncommitted operations in it and try to apply it. If the operations contain the creation of an entity (as is the case), there is no way to get rid of them with the same process (delete is not implemented), so they leave garbage in ftrack which will also fail the test the next time it is run (duplicate entry).

Since the database write/read feature seems incomplete I would assume it is barely used if at all. I started a discussion, and based on its outcome, either remove the functionality together with its tests or implement the missing feature.

@99alfie
Copy link
Collaborator

99alfie commented Aug 21, 2023

Tests were failing because of modifications done in branch fix/i10-pytests. Reverting them resolved the confusion. All tests are working now.

@99alfie 99alfie linked a pull request Aug 21, 2023 that will close this issue
Fix/i10 pytests #65
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salvaom salvaom

@99alfie 99alfie

Labels
CI Continuous Integration enhancement New feature or request
Projects
None yet
Milestone
v0.1.0rc6
Development

Successfully merging a pull request may close this issue.

Fix/i10 pytests TrixterFilm/trackteroid
3 participants
@salvaom @rkoschmitzky @99alfie