Skip to content

Commit

Permalink
Remove submodule and fetch the data in a custom build step instead
Browse files Browse the repository at this point in the history
  • Loading branch information
Trivernis committed Feb 28, 2024
1 parent 2f241cb commit 52bc103
Show file tree
Hide file tree
Showing 6 changed files with 88 additions and 13 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
Cargo.lock
.idea
jtd-codegen
minecraft-data
3 changes: 0 additions & 3 deletions .gitmodules

This file was deleted.

15 changes: 12 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
[package]
name = "minecraft-data-rs"
version = "0.8.0"
version = "0.8.1"
authors = ["trivernis <[email protected]>"]
edition = "2021"
readme = "README.md"
license = "MIT"
description = "A wrapper for minecraft-data"
repository = "https://github.com/Trivernis/minecraft-data-rs"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
[package.metadata]
minecraft_data_repo = "https://github.com/PrismarineJS/minecraft-data.git"
minecraft_data_commit = "46b78398b6f351958e02fbd266424f0ee0ab138b"

[dependencies]
thiserror = "1.0.38"
Expand All @@ -19,7 +21,14 @@ include_dir = { version = "0.7.3", optional = true }
itertools = { version = "0.10.5", optional = true }
lazy_static = { version = "1.4.0", optional = true }

[build-dependencies]
git2 = {version = "0.18.2", optional = true}
dirs = {version = "5.0.1", optional = true}
cargo_toml = {version = "0.19.1", optional = true}
serde = { version = "1.0.151", features = ["derive"], optional = true }

[features]
default = ["include-data", "api"]
include-data = ["include_dir", "itertools", "lazy_static"]
include-data = ["include_dir", "itertools", "lazy_static", "git2", "dirs", "cargo_toml", "serde/derive"]
api = ["include-data"]

73 changes: 73 additions & 0 deletions build.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
#[cfg(not(feature = "include-data"))]
fn main() {}

#[cfg(feature = "include-data")]
fn main() {
data_repo::init_repo();
}

#[cfg(feature = "include-data")]
mod data_repo {
use std::{env, fs, path::PathBuf};

use cargo_toml::Manifest;
use git2::{Oid, Repository};
use serde::Deserialize;

#[derive(Clone, Debug, Deserialize)]
struct Metadata {
minecraft_data_repo: String,
minecraft_data_commit: String,
}

pub fn init_repo() {
println!("cargo:rerun-if-env-changed=MINECRAFT_DATA_REPO_PATH");
println!("cargo:rerun-if-changed=Cargo.toml");

let manifest = Manifest::<Metadata>::from_path_with_metadata(PathBuf::from("Cargo.toml"))
.expect("Failed to read manifest (Cargo.toml)");
let metadata = manifest
.package
.expect("missing package info in Cargo.toml")
.metadata
.expect("missing package.metadata in Cargo.toml");

let repo_path = env::var("MINECRAFT_DATA_REPO_PATH")
.map(PathBuf::from)
.ok()
.or_else(|| dirs::cache_dir().map(|p| p.join("minecraft-data")))
.unwrap_or_else(|| PathBuf::from("minecraft-data"));

println!(
"cargo:rustc-env=MINECRAFT_DATA_PATH_INTERNAL={}",
repo_path.to_string_lossy()
);

let version_oid = Oid::from_str(&metadata.minecraft_data_commit).expect("invalid oid");

let repo = if repo_path.exists() {
let repo = Repository::open(&repo_path).expect("failed to open git repo");
let head_oid = repo
.head()
.expect("no head found in repo")
.peel_to_commit()
.expect("head is not a commit")
.as_object()
.id();
if head_oid != version_oid {
fs::remove_dir_all(&repo_path).expect("could not delete repository");
Repository::clone(&metadata.minecraft_data_repo, repo_path)
.expect("failed to clone repo")
} else {
repo
}
} else {
Repository::clone(&metadata.minecraft_data_repo, repo_path)
.expect("failed to clone repo")
};

repo.set_head_detached(version_oid)
.expect("failed set head");
repo.checkout_head(None).expect("failed checkout index")
}
}
1 change: 0 additions & 1 deletion minecraft-data
Submodule minecraft-data deleted from 46b783
8 changes: 2 additions & 6 deletions src/data/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use crate::models::version::Version;
use crate::{DataError, DataResult};
use include_dir::Dir;

pub static MINECRAFT_DATA: Dir = include_dir::include_dir!("minecraft-data/data");
pub static MINECRAFT_DATA: Dir = include_dir::include_dir!("$MINECRAFT_DATA_PATH_INTERNAL/data");

pub static BIOMES_FILE: &str = "biomes";
pub static BLOCK_LOOT_FILE: &str = "blockLoot";
Expand Down Expand Up @@ -69,11 +69,7 @@ pub fn get_path(version: &Version, filename: &str) -> DataResult<String> {
.pc
.get(&version.minecraft_version)
// fallback to major version
.or_else(||
PATHS
.pc
.get(&version.major_version)
)
.or_else(|| PATHS.pc.get(&version.major_version))
.ok_or_else(|| DataError::NotFoundError(version.minecraft_version.clone()))?
.get(filename)
.cloned()
Expand Down

0 comments on commit 52bc103

Please sign in to comment.