Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landlord Listing Form + Unit Details Updates #106

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

YashRavipati1
Copy link
Contributor

Tracking Info

Resolves #98

Changes

  1. Updated Unit Details page such that only HLs can update the HL column for a referral
  2. Added utilities component to landlord listing form and unit details

Testing

Looked at a unit details page from both a HL account and a non-HL account to verify the referral table.
Went through entire workflow of landlord listing form to create unit - validated that utilities were successfully added and showing up on unit details.

Confirmation of Change

Screenshot 2024-05-29 at 2 10 51 AM

HL Account:
Screenshot 2024-05-29 at 2 11 08 AM

Non-HL Account:
Screenshot 2024-05-29 at 2 11 51 AM

@YashRavipati1 YashRavipati1 changed the title Feature/yash/landlord unit updates Landlord Listing Form + Unit Details Updates May 29, 2024
Copy link

github-actions bot commented May 29, 2024

Visit the preview URL for this PR (updated for commit c65d139):

https://ushs-housing-portal-staging--pr106-feature-yash-landlo-a9r1qxq4.web.app

(expires Sat, 08 Jun 2024 01:03:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7c2f834b767adfbe0b81630135daffa0bb77f003

@petabite petabite requested a review from Azhou2023 May 29, 2024 20:28
Copy link
Contributor

@Azhou2023 Azhou2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just one comment about maybe a potential N/A field for the utilities section?

backend/src/validators/units.ts Show resolved Hide resolved
Copy link
Member

@petabite petabite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 🔥

@petabite petabite merged commit fd5e714 into main Jun 1, 2024
4 checks passed
@petabite petabite deleted the feature/Yash/LandlordUnitUpdates branch June 1, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landlord Form + Unit Details Updates
3 participants