Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Housekeeping #105

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

Azhou2023
Copy link
Contributor

Tracking Info

Resolves #99

Changes

  • Formatted phone number in unit details page to nice (xxx) xxx-xxxx format
  • Added section separators in unit details page and reformatted some text
  • Made address clickable in unit details page which leads to google maps page for it
  • Changed UserDropdown icon to up/down arrow for referral table
  • Moved "Add Listing" button to top of the page
  • Implemented deletion of all unit referrals when an unit is deleted

Testing

Thoroughly tested all frontend elements and made sure they looked like what was specified by Figma. Tried a bunch of different addresses and made sure they all loaded in google maps. Tested referral deletion with multiple units and ensured that it deleted all the relevant referrals and nothing else.

Confirmation of Change

Screenshot 2024-05-26 at 6 07 14 PM Screenshot 2024-05-26 at 6 07 24 PM Screenshot 2024-05-26 at 6 07 57 PM Screenshot 2024-05-26 at 6 08 15 PM

Copy link

github-actions bot commented May 27, 2024

Visit the preview URL for this PR (updated for commit 2760010):

https://ushs-housing-portal-staging--pr105-feature-andrew-unit-19364udg.web.app

(expires Wed, 12 Jun 2024 22:22:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7c2f834b767adfbe0b81630135daffa0bb77f003

Copy link
Member

@petabite petabite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

frontend/src/components/FilterDropdown.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@PoliteUnicorn PoliteUnicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! Thanks for making the delete referral route :D

@Azhou2023 Azhou2023 merged commit 61126da into main Jun 5, 2024
4 checks passed
@Azhou2023 Azhou2023 deleted the feature/andrew/UnitDetailHousekeeping branch June 5, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor Unit Details Page Updates
3 participants