Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit List View #102

Merged
merged 28 commits into from
Jun 4, 2024
Merged

Unit List View #102

merged 28 commits into from
Jun 4, 2024

Conversation

PoliteUnicorn
Copy link
Contributor

Tracking Info

Resolves #93

Changes

Implemented the card/list view toggle button at the top of the page and the list view for units.
Also replaced paginator with V2 button version.

Testing

Tested by switching between unit and list views and trying the paginator on varying numbers of pages.

Confirmation of Change

The implemented list view:
Screenshot 2024-05-22 at 1 03 12 PM
Screenshot 2024-05-22 at 1 03 19 PM

The paginator:
Screenshot 2024-05-22 at 1 03 42 PM
Screenshot 2024-05-22 at 1 03 54 PM
Screenshot 2024-05-22 at 1 04 00 PM
Screenshot 2024-05-22 at 1 04 06 PM

Copy link

github-actions bot commented May 22, 2024

Visit the preview URL for this PR (updated for commit f6decbc):

https://ushs-housing-portal-staging--pr102-karen-unit-list-vie-5x1mcvcd.web.app

(expires Tue, 11 Jun 2024 04:13:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7c2f834b767adfbe0b81630135daffa0bb77f003

Copy link
Member

@petabite petabite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Left some small comments below. Also, do you think it is possible to vertically center the content in each list item?

image

frontend/public/Group.svg Outdated Show resolved Hide resolved
frontend/src/components/ReferralTable.tsx Outdated Show resolved Hide resolved
frontend/src/components/Table.tsx Show resolved Hide resolved
Copy link
Contributor Author

@PoliteUnicorn PoliteUnicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed changes!

Copy link
Member

@petabite petabite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the row content isn't vertically centered yet.

Also, do you think you can fix the spacing of the "No matching units found" text here?

image

@PoliteUnicorn
Copy link
Contributor Author

Fixed alignment issues and text.

Copy link
Member

@petabite petabite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! 🚢

Copy link
Contributor

@RamtinTJB RamtinTJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯 🗿

@petabite petabite changed the title Karen/unit list view Unit List View Jun 4, 2024
@petabite petabite merged commit fcc8dac into main Jun 4, 2024
4 checks passed
@petabite petabite deleted the karen/unit-list-view branch June 4, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Unit Browsing - Units List View
3 participants