Nirmal MVP Finalization #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put in login and signup page, linked to firebase auth
Set up user register to store display name as well
…onSE/SDCTA-Data-Visualization-Website into Feature/vs2961/backend-auth
auth.tsx is file containing function calls to backend
…onSE/SDCTA-Data-Visualization-Website into Feature/vs2961/backend-auth
Getting register post request to backend setup
Added a confirm password field, as well as error handling for any sign up errors, such as the password not being long enough, the terms and services checkbox not being checked, email not being in use, or full name not being typed in. Added an error_handling folder with an auth-errors file used to handle the errors that arise when trying to register a user.
added error handling for login page, such as wrong password or user not found
Setup Signup With Google using Firebase. Added google sign in button to signup form. CSS Styling still required.
commit 3f342fd Author: Samvrit Srinath <[email protected]> Date: Tue Feb 7 22:18:50 2023 -0800 Feature/SamvritSrinath/Landing-Page (#10) * Basic React for Landing Page Used JSX(will return to EM for feedback) * modified: ../.DS_Store modified: package-lock.json modified: package.json modified: src/App.jsx modified: src/components/Body.jsx modified: src/components/NavBar.jsx src/Images/ * new file: SDCTA/src/Images/Graph.jpg new file: SDCTA/src/Images/SDTEF Logo Transparent Background 1.jpg new file: SDCTA/src/Images/unsplash_dsV4yvL5UJk.jpg * changed jsx to tsx * added separate css file for body component * modified: src/App.css modified: src/App.tsx new file: src/components/Footer.css modified: src/components/Footer.tsx deleted: src/components/NavBar.jsx * Images in Body * Added Education Images modified: src/components/Body.tsx * changed heading * Updating Footer Style modified: src/components/Footer.css * Updating Footer Style again modified: src/components/Footer.css * Fixing white space modified: src/components/Footer.css modified: src/components/body.css new file: src/pages/LandingPage.tsx * put in new images & added image styling * Formatting into a page modified: src/App.tsx modified: src/pages/LandingPage.tsx * Image Refactor modified: src/App.css deleted: src/Images/unsplash_dsV4yvL5UJk.jpg deleted: src/components/Body.tsx deleted: src/components/body.css modified: src/pages/LandingPage.tsx * Landing Page_Body Refactor * Images renamed: src/components/Landing Page/Body.tsx -> src/components/Landing_Page/Body.tsx renamed: src/components/Landing Page/body.css -> src/components/Landing_Page/body.css modified: src/pages/LandingPage.tsx * Final Images renamed: src/components/Footer.css -> src/components/Footer/Footer.css renamed: src/components/Footer.tsx -> src/components/Footer/Footer.tsx modified: src/components/Landing_Page/Body.tsx modified: src/pages/LandingPage.tsx --------- Co-authored-by: meganleongg <[email protected]>
---- or ----, checkbox, and sign in with google button need to be styled/fixed still.
navigates to home page after successful login
made error message pop up under corresponding input box
Added "forgot your password" field, need to implement functionality. Added sign up for free part.
…eFrontend' into Nirmal-MVP-Finalization
| throw ServiceError.STRIPE_FAILURE.addContext(error); | ||
| } | ||
| } | ||
| // async function createStripeUser(name, email) { |
There was a problem hiding this comment.
Is it alright for all of these comments to be deployed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #
Make sure your branch name conforms to:
<feature|staging|bugfix|...>/<username>/<3-4 word description separated by dashes>. Otherwise, please rename your branch and create a new PR.Changes
What changes did you make?
Testing
How did you confirm your changes worked?
Confirmation of Change
Run the backend and frontend using the instructions on the respective README's.