-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/leo3friedman/dropdown keyboard interactable #61
base: main
Are you sure you want to change the base?
Feature/leo3friedman/dropdown keyboard interactable #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the styling problem on Step 4 and a small note on the name attribute, looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<select | ||
className={`${styles.select} ${selected === defaultSelected ? styles.unselected : ""}`} | ||
onChange={onSelectChange} | ||
required={required} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smll thing; can we add a name attribute to this that could be passed in through the props?
Tracking Info
Resolves #56
Changed Dropdown to use select element
Removed unnecessary inputs
Testing
Manual testing
Confirmation of Change