Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sidhant/step5 #54

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Feature/sidhant/step5 #54

wants to merge 11 commits into from

Conversation

sidhantrohatgi
Copy link
Member

Tracking Info

Resolves #14

Changes

Added Step 5

  • TODO

Testing

Ran the frontend and checked if the changes were reflected according to the figma

Confirmation of Change

Screenshot 2024-05-09 at 18 03 34

Copy link
Member

@Miyuki-L Miyuki-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few things to clean up and also the button in the bottom navigator when on payment page

.DS_Store Outdated Show resolved Hide resolved
backend/.DS_Store Outdated Show resolved Hide resolved
frontend/src/components/Step5.module.css Outdated Show resolved Hide resolved
frontend/src/components/Step5.module.css Show resolved Hide resolved
frontend/src/components/Step5.tsx Outdated Show resolved Hide resolved
<br />

<div className={styles.centerButton}>
<Button onClick={undefined} additionalStyle={styles.paymentportalbutton}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link it to the current websites payments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the bottom navigator such that is is the Submit & Close button if we are on the step5 part

frontend/src/components/Step5.tsx Outdated Show resolved Hide resolved

return (
<>
<form id="step5-form" onSubmit={onSubmit}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the border/shaow between the element and the background.
image

See how there is a shadow/border on the top component but there isn't one on the bottom one

Copy link
Contributor

@leo3friedman leo3friedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one question about why we use a form for Step5. Also, looks like you may want to merge main into this branch + resolve conflicts. Besides that, looks good!

frontend/src/components/Step5.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Step 5 Component
4 participants