-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sidhant/step5 #54
base: main
Are you sure you want to change the base?
Conversation
Made Temporary path called Step 3 for visualization, Added WorkExperienceForm and Step 3 Components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few things to clean up and also the button in the bottom navigator when on payment page
<br /> | ||
|
||
<div className={styles.centerButton}> | ||
<Button onClick={undefined} additionalStyle={styles.paymentportalbutton}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link it to the current websites payments
frontend/src/pages/Application.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the bottom navigator such that is is the Submit & Close button if we are on the step5 part
|
||
return ( | ||
<> | ||
<form id="step5-form" onSubmit={onSubmit}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one question about why we use a form for Step5. Also, looks like you may want to merge main into this branch + resolve conflicts. Besides that, looks good!
Tracking Info
Resolves #14
Changes
Added Step 5
Testing
Ran the frontend and checked if the changes were reflected according to the figma
Confirmation of Change