123 fix compilation with GCC9 (#124)

Reviewed by: Tim Foster <[email protected]>
TritonDataCenter · May 7, 2020 · 64f1ccd · 64f1ccd
1 parent 89823b6
commit 64f1ccd
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -5,11 +5,15 @@
 -->
 
 <!--
-    Copyright 2019 Joyent, Inc.
+    Copyright 2020 Joyent, Inc.
 -->
 
 # mdb_v8 changelog
 
+## v1.4.2 (2020-05)
+
+* #123 fix compilation with GCC9
+
 ## v1.4.1 (2019-08)
 
 * OS-7960 need fixes for NULL as a pointer

diff --git a/README.md b/README.md
@@ -44,17 +44,17 @@ https://us-east.manta.joyent.com/Joyent_Dev/public/mdb_v8.  If you have the
 can list the latest binaries with:
 
     $ mfind -t o $(mget -q /Joyent_Dev/public/mdb_v8/latest)
-    /Joyent_Dev/public/mdb_v8/v1.4.1/mdb_v8_amd64.so
-    /Joyent_Dev/public/mdb_v8/v1.4.1/mdb_v8_ia32.so
+    /Joyent_Dev/public/mdb_v8/v1.4.2/mdb_v8_amd64.so
+    /Joyent_Dev/public/mdb_v8/v1.4.2/mdb_v8_ia32.so
 
 You can fetch a specific binary like this (in this case, the 32-bit version
-1.4.1 binary):
+1.4.2 binary):
 
-    $ mget -O /Joyent_Dev/public/mdb_v8/v1.4.1/mdb_v8_ia32.so
+    $ mget -O /Joyent_Dev/public/mdb_v8/v1.4.2/mdb_v8_ia32.so
 
 or using curl:
 
-    $ curl -O https://us-east.manta.joyent.com/Joyent_Dev/public/mdb_v8/v1.4.1/mdb_v8_ia32.so
+    $ curl -O https://us-east.manta.joyent.com/Joyent_Dev/public/mdb_v8/v1.4.2/mdb_v8_ia32.so
 
 This one-liner will get you the latest 32-bit binary:
 

diff --git a/src/mdb_v8.c b/src/mdb_v8.c
@@ -5,7 +5,7 @@
  */
 
 /*
- * Copyright 2019 Joyent, Inc.
+ * Copyright 2020 Joyent, Inc.
  */
 
 /*
@@ -2557,7 +2557,7 @@ jsobj_properties(uintptr_t addr,
 		if (kind == V8_ELEMENTS_FAST_ELEMENTS ||
 		    kind == V8_ELEMENTS_FAST_HOLEY_ELEMENTS) {
 			for (ii = 0; ii < len; ii++) {
-				char name[10];
+				char name[21];
 
 				if (kind == V8_ELEMENTS_FAST_HOLEY_ELEMENTS &&
 				    jsobj_is_hole(elts[ii]))

diff --git a/version b/version
@@ -8,4 +8,4 @@
 #
 # This value is also used by the "publish" target in the build process.
 #
-1.4.1
+1.4.2
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,4 +8,4 @@ @@
     #
     # This value is also used by the "publish" target in the build process.
     #
-.4.1
+.4.2