[feat] 마이페이지 알림 보관 리스트 기능 구현 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meena2003
approved these changes
Jan 26, 2024
| public class AlarmController { | ||
|
|
||
| private final AlarmService alarmService; | ||
|
|
| private final AlarmService alarmService; | ||
|
|
||
|
|
||
| @GetMapping("/v1/member/alarms") |
| NEW_PLACE_REVIEW_COMMENT("새 여행지리뷰 댓글 알림"), | ||
| REVIEW_WRITE_REQUEST("리뷰 작성 요청 알림"); | ||
|
|
||
| private final String message; |
There was a problem hiding this comment.
각각의 타입마다 message가 있는데 해당 message가 사용되는 곳이 어디인가요? 찾지 못한 것 같아서요
| public class AlarmService { | ||
|
|
||
| private final AlarmRepository alarmRepository; | ||
|
|
| private String createAlarmArgs(String memberNickname, AlarmType alarmType) { | ||
| switch (alarmType) { | ||
| case NEW_TRIP_RECORD_REVIEW: | ||
| return memberNickname + "님이 여행 후기에 리뷰를 남기셨습니다."; |
There was a problem hiding this comment.
차라리 "~님이 여행 후기에 리뷰를 남기셨습니다" 라는 문구를 alarmType의 message 형태로 사용하는 건 어떨까요? 지금은 하드코딩의 느낌이 납니다 ㅎㅎ
| .alarmType(alarmType) | ||
| .windowId(windowId) | ||
| .objectId(objectId) | ||
| .alarmArgs(alarmArgs) |
There was a problem hiding this comment.
위에 alarmArgs 변수 선언 대신 바로 인라인 하면 코드가 더 줄어들 것 같아요 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 목적
새 기능 (New Feature)
리팩토링 (Refactoring)
버그 수정 (Bug Fix)
테스트 (Test)
CI/CD
설정 (Setup)
간략한 설명:
: 댓글/리뷰 작성에 대한 마이페이지 내부 알림 보관 리스트 기능 구현
🛠 작성/변경 사항
🔗 관련 이슈
💡 특이 사항