Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ckeditor table background color in dark mode #429

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix ckeditor table background color in dark mode #429

wants to merge 2 commits into from

Conversation

JYC333
Copy link

@JYC333 JYC333 commented Sep 13, 2024

Bug reports from Element.

image

eliandoran
eliandoran requested changes Sep 13, 2024
View reviewed changes
Copy link

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that there is a regression on the hover color:

Before:

image

After:

image

The color is important in order to easily distinguish the active cell.

@eliandoran eliandoran marked this pull request as draft September 13, 2024 19:33
@JYC333
Copy link
Author

JYC333 commented Sep 13, 2024

It's actually on purpose, the color here will make the text hard to see.

image

Now I change to

image

Hope this color is good enough, I'm not good at color stuff

@JYC333 JYC333 marked this pull request as ready for review September 13, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliandoran eliandoran Awaiting requested review from eliandoran

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JYC333 @eliandoran