Fix RpmPlugin so that using the "with" method does not throw an exceptio... #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion and can be used.
|
This has been deployed to Sonatype OSS snapshots as 1.5-SNAPSHOT https://oss.sonatype.org/content/repositories/snapshots/ |
|
Alan, Thanks! |
|
The idea of supporting "with" is great, but I'm concerned about the modification of the Gradle class WrapperCopySpec via metaclass. You're adding fields to EVERY CopySpec, even though they aren't relevant to everyone, and they could conflict with other plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...n and can be used.
Added getters to the CopySpecImpl.WrapperCopySpec to allow the RPM plugin to support a CopySpec's "with" method. Aliased the Redline Enums and constants to the CopySpec class so that they are available in a generic CopySpec definition.
This pull request addresses this issue:
#39