Fixed the tray icon not appearing on Mac #8231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
force-pushed
the
fix_mac_tray
branch
2 times, most recently
from
408197a
to
0dd3c0b
Compare
qstokkink
changed the title
qstokkink
force-pushed
the
fix_mac_tray
branch
from
0dd3c0b
to
ac29578
Compare
egbertbouman
approved these changes
Oct 23, 2024
qstokkink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8229
This PR:
Macbecause it was not spawned in the main thread.Regarding the note in
mac_event_loop: the asyncio main thread blocks while the tray icon context menu is open. I assume nobody will keep their menu open, but should they do so their Tribler core won't do anything anymore. Even so, it would be nice to fix that in the future. For now, I think this is better than nothing.The choice for
asyncio.sleep(0.01)instead ofasyncio.sleep(0)was because the latter chokes up the core. With0.01, the core seems unaffected.