Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache libsodium.dll from the main branch #1295

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Cache libsodium.dll from the main branch #1295

merged 2 commits into from
Jun 13, 2024

Conversation

qstokkink
Copy link
Collaborator

@qstokkink qstokkink commented Jun 13, 2024 •
edited
Loading

Fixes #1294

This PR:

  • Fixes the Mac unit tests not finding libsodium.dylib.
  • Updates the coverage job to be periodic (with the intent of refreshing a cache).
  • Removes cache storage from the unittest job (this was doing very little).

@qstokkink
Copy link
Collaborator Author

validate

@qstokkink qstokkink marked this pull request as ready for review June 13, 2024 09:22
@qstokkink qstokkink changed the title WIP: Cache libsodium.dll from the main branch READY: Cache libsodium.dll from the main branch Jun 13, 2024
@qstokkink qstokkink changed the title READY: Cache libsodium.dll from the main branch Cache libsodium.dll from the main branch Jun 13, 2024
@qstokkink qstokkink merged commit 2cb4280 into Tribler:master Jun 13, 2024
6 checks passed
@qstokkink qstokkink deleted the upd_github_wincaching branch June 13, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Actions caching is useless
2 participants
@qstokkink @egbertbouman