Fixed relaying to exits #1292
Merged
Fixed relaying to exits #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egbertbouman
force-pushed
the
fix_exit_relay
branch
from
92863c1
to
a74b8a5
Compare
|
The linting errors are because a bug in ruff 0.3.5. |
|
Please don't pin the ruff version 🙏 I'd rather merge with ruff violation(s): they update releases every few weeks anyway. |
egbertbouman
force-pushed
the
fix_exit_relay
branch
from
d883798
to
a74b8a5
Compare
|
validate |
egbertbouman
force-pushed
the
fix_exit_relay
branch
from
d529267
to
6720970
Compare
egbertbouman
force-pushed
the
fix_exit_relay
branch
from
6720970
to
c436e50
Compare
|
validate |
qstokkink
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, peers in the
TunnelCommunitywill suggest extending to peers that just havePEER_FLAG_RELAYset, and notPEER_FLAG_EXIT_BT. This is meant to remove some of the strain on the exit nodes.However, the circuit creator will currently only try to extend to the suggested peers. This means that circuit creation can needlessly fail. For instance, it's currently not possible to create a 2-hop circuit in a network that consists only of exit nodes, even if the exit nodes all have
PEER_FLAG_RELAYset.This PR addresses this issue by letting the circuit creator extend to non-suggested exit nodes as well.