Merge pull request #1312 from mg98/fix/configbuilder-file-key

Fix missing file key in ConfigBuilder
Tribler · Oct 16, 2024 · 254eb86 · 254eb86
2 parents a9330c8 + adf622e
commit 254eb86
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ipv8/configuration.py b/ipv8/configuration.py
@@ -396,8 +396,7 @@ def add_key_from_bin(self, alias: str, key_bin_b64: str, file_path: str | None =
             'alias': alias,
             'bin': key_bin_b64
         }
-        if file_path is not None:
-            key_config['file'] = file_path
+        key_config['file'] = file_path or ""
         self.config['keys'].append(key_config)
         return self
 

diff --git a/ipv8/test/test_configuration.py b/ipv8/test/test_configuration.py
@@ -188,7 +188,8 @@ def test_add_key_from_bin(self) -> None:
 
         expected = {
             'alias': "my new key",
-            'bin': key_material
+            'bin': key_material,
+            'file': ""
         }
         keys = builder.finalize()['keys']