Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing and tweaking the utils.question module #102

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RichardBruskiewich
Copy link

@RichardBruskiewich RichardBruskiewich commented Jan 16, 2024

Experience with the PLATER code in other contexts suggested some small improvements, which are captured in this PR. This PR is being kept in 'draft' for pending some additional iterative work (and unit test updates)

  • Added 'supporting_data_source' parsing to _construct_sources_tree(), plus other tweaks and a unit test to validate
  • Cleaned up format_attribute_trapi() adding a few checks for missing (or previously set) key fields
  • Removed unused parameter "graph_interface: GraphInterface" in Question.transform_attributes()
  • Added back in code to remove 'biolink:' prefix in resource_role values; fixed unit tests and reformatted some test data (for readability)

@RichardBruskiewich RichardBruskiewich marked this pull request as ready for review January 16, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant